Browse Source

fw_printenv: Fix crash due to incorrect size for malloc'ed string.

Using sizeof gives the size of the pointer only, not the string. This
could easily lead to crashes when using -l argument.

Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>
master
Kristian Amlie 2 years ago
committed by Tom Rini
parent
commit
8a0b827b1a
1 changed files with 1 additions and 1 deletions
  1. +1
    -1
      tools/env/fw_env_main.c

+ 1
- 1
tools/env/fw_env_main.c View File

@@ -239,7 +239,7 @@ int main(int argc, char *argv[])
argv += optind;

if (env_opts.lockname) {
lockname = malloc(sizeof(env_opts.lockname) +
lockname = malloc(strlen(env_opts.lockname) +
sizeof(CMD_PRINTENV) + 10);
if (!lockname) {
fprintf(stderr, "Unable allocate memory");


Loading…
Cancel
Save