Browse Source

dm: core: Supress dead-code warning in __of_get_next_child()

Suppress a warning on next = next->sibling.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reported-by: Coverity (CID: 163245)
Fixes 644ec0a (dm: core: Add livetree access functions)
tags/2020-06-01
Simon Glass 4 years ago
committed by Tom Rini
parent
commit
73027a853d
1 changed files with 6 additions and 0 deletions
  1. +6
    -0
      drivers/core/of_access.c

+ 6
- 0
drivers/core/of_access.c View File

@@ -244,6 +244,12 @@ static struct device_node *__of_get_next_child(const struct device_node *node,
return NULL;

next = prev ? prev->sibling : node->child;
/*
* coverity[dead_error_line : FALSE]
* Dead code here since our current implementation of of_node_get()
* always returns NULL (Coverity CID 163245). But we leave it as is
* since we may want to implement get/put later.
*/
for (; next; next = next->sibling)
if (of_node_get(next))
break;